Server middleware refactor PRs #881
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server : refactor middleware and /health endpoint (#9056) * server : refactor middleware and /health endpoint * move "fail_on_no_slot" to /slots * Update examples/server/server.cpp * fix server tests * fix CI * update server docs server : fix crash when error handler dumps invalid utf-8 json (#9195)
|
I'm not very familiar with the server code, so invite review by others. |
|
@saood06 , @firecoperana , could any of your folks get a look at this PR when you have some spare time? |
|
I just tried this PR, and I don't see any errors when using the webui. This PR changes return results for endpoints like health. It also removed Access-Control-Allow-Origin in all endpoints. This is good from the security perspective, but not sure how it affects others. It could be no issue since it was merged in mainline a long time ago. |
|
Great! Then one more pair of eyes, and then, we're good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuing on my quest to update a bit the server, here's the Middleware refactor, following straight the bunch of 6 server PRs merged recently.
Here are the mainline PRs involved:
server : refactor middleware and /health endpoint (#9056)
server : fix crash when error handler dumps invalid utf-8 json (#9195)
This time, I had to solve a bunch of conflicts, of course.
On my side, it works properly, and I tried speculative decoding as well without apparent bug, but I need a review by someone more competent before it can be merged, if pertinent.